fix: per-gatherer excludeAnnotationKeysRegex now excludes resources from upload#797
Merged
SgtCoDFish merged 1 commit intomasterfrom May 5, 2026
Merged
Conversation
FelixPhipps
force-pushed
the
exclude-annotation-fix-VC-52471
branch
from
226b60a to
8459802
Compare
SgtCoDFish
requested changes
May 5, 2026
Contributor
SgtCoDFish
left a comment
SgtCoDFish
left a comment
There was a problem hiding this comment.
Got a few bits and bobs although I think really this is close!
FelixPhipps
force-pushed
the
exclude-annotation-fix-VC-52471
branch
2 times, most recently
from
3f9ccba to
ef5e959
Compare
FelixPhipps
force-pushed
the
exclude-annotation-fix-VC-52471
branch
from
ef5e959 to
888599a
Compare
SgtCoDFish
approved these changes
May 5, 2026
Contributor
SgtCoDFish
left a comment
SgtCoDFish
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where annotation/label-based exclusion rules had no effect on which resources were uploaded to TLSPK.
Two issues were present:
Fix: Added excludeAnnotationKeysRegex and excludeLabelKeysRegex to ConfigDynamic so per-gatherer config is correctly parsed. Added excludeResources() called in Fetch() before redactList(), which drops any resource whose annotation or label keys match the configured patterns. Both the per-gatherer and top-level config formats now work as customers expect.
Automated testing added to PR.